Repository navigation
Move to Hugo v0.169.0 and the latest site-commons - #94
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hugo v0.162.0 and newer deny `text/html` content files by default. The full-screen architecture diagram is one, so the build failed. The setting has to be in the project config: Hugo ignores `security` in the config of an imported module. Fixes #92. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name the HTML content file and the site that needs the same setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
No active review issues require resolution for the documentation preview upgrade.
No open issues 🎉
What changed in this PR
Updates the documentation preview to Hugo v0.169.0 and the latest site-commons, enabling HTML content files and adopting bundled code-highlighting palettes.
Changes:
- Allows the full-screen architecture diagram’s HTML content while keeping Org-mode content denied.
- Updates the theme dependency and documents Go 1.27.3 and Hugo Extended v0.169.0 prerequisites.
- Aligns the link-check workflow’s Hugo version and records verification results and follow-ups.
| File | Description |
|---|---|
README.md |
Updates Go and Hugo prerequisites. |
docs/_preview/hugo.toml |
Allows HTML content and explains the per-site configuration requirement. |
docs/_preview/go.sum |
Adds checksums for the updated theme. |
docs/_preview/go.mod |
Updates site-commons and raises the Go directive to 1.27.3. |
.github/workflows/check-links.yml |
Updates the Hugo pin to 0.169.0. |
.agents/tasks/hugo-0-169-upgrade.md |
Records the upgrade plan, verification results, and remaining follow-ups. |
Review effort: Balanced
alexander-yevsyukov
added a commit
to SpineEventEngine/SpineEventEngine.github.io
that referenced
this pull request
Oct 30, 2026
Move `documentation/docs` to the `documentation` master, which has SpineEventEngine/documentation#94 merged. That PR changes only `docs/_preview`, a separate Go module, so the imported content and the built site stay the same; only the pinned version changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the documentation preview to Hugo v0.169.0 and the latest
site-commonstheme.Fixes #92.
Fixes #93.
Part of #89.
Changes
Allow HTML content files (#92)
docs/_preview/hugo.tomlnow has:This is option A from #92. Since Hugo v0.162.0,
text/htmlcontent files are denied by default. The full-screen architecture diagram is one, so the build failed on newer Hugo versions.unsaferenderer is already on, so Markdown pages can already contain raw HTML.docs/hugo.toml. Hugo ignoressecurityin the config of an imported module, so each site that importsdocsneeds it. The comment inhugo.tomlsays so.Update
site-commons(#93)hugo mod get -u github.com/SpineEventEngine/site-commonspicked up SpineEventEngine/site-commons#36 and SpineEventEngine/site-commons#37.main.css.module.hugoVersion.min) and Go 1.27.3. Go raised thegodirective indocs/_preview/go.modto1.27.3to match.Hugo v0.169.0 (#89)
HUGO_VERSIONincheck-links.ymlis now0.169.0. The theme's relative partial paths need at least v0.167.0, so link checks can't run on v0.161.1 anymore.README.mdnow lists Hugov0.169.0and Go1.27.3as prerequisites.I went through the release notes from v0.162.0 to v0.169.0. The two shortcodes in this repo don't need changes or benefit from the new features. The theme adopted them in SpineEventEngine/site-commons#36.
Verification
All builds used Hugo v0.169.0 extended and Go 1.27.3.
docs/_previewonmasteraccess denied: "text/html" is not whitelisted in policy "security.allowContent"docs/_previewwithallowContentdocs/_previewwith the new themeallowContentsemantics, on a scratch site.htmlaccepted,.orgstill deniedOutput with the old and the new theme. I compared the two builds with the asset fingerprints normalised and whitespace ignored.
code-theme/*.csslink.cloakemailon one page, which change on every build.code-theme/light.cssandcode-theme/dark.cssare gone; thehl-text-onlyrules are now inmain.css.In the browser, with
hugo server:architecture-diagram.jsand the inline SVG, with no console errors.hl-text-onlyline keeps its emphasis.<head>script setsdata-themebeforemain.cssloads.spine.io, on a fresh clone with the new theme and this repo'sdocsas the module:allowContent, the build fails with the same error.allowContent = ['! ^text/org$']insite/config/_default/hugo.toml,hugo --minifybuilds. The full-screen page, its script and the PDF are published.Link check. Lychee 0.24.2 with
lychee.tomlagainsthugo -e developmentpasses, but that result says little.<head>URLs from our pages. Every page has an inline jQuery block in<head>, and after it Lychee finds no links in the body.masterreported8 Unique ✅ 616 OKfor 77 pages.master, so none comes from this PR.validation/docsmodule, e.g.../06-developers-guide/and links to moved.agents/*files./a/link inguides/validation.md. It redirects to a/questions/page, which answers 403 to bots.Follow-ups
spine.ioneeds the sameallowContentsetting, the theme update, andHUGO_VERSION: 0.169.0ingh-pages.ymlandcheck-links.yml. This is thespine.iopart of Upgrade Hugo to v0.169.0 #89.configdistributescheck-links.ymland still pinsHUGO_VERSION: 0.161.1. The next./config/pullwould bring that back here, soconfigneeds the same bump.site-commonsor in theconfigworkflow, will turn up the 13 broken links, so they need fixing then too.WARN deprecated: css.Sass: libsass was deprecated in Hugo v0.153.0. The call is in the theme'sstylesheet.html, and the warning shows onmastertoo. Moving to Dart Sass is tracked in Move from LibSass to Dart Sass site-commons#38.🤖 Generated with Claude Code